[dsmr] Catch exceptions for RFC2217 compatibility #8420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wouter Born <[email protected]>
Hilbrand
approved these changes
Sep 7, 2020
There was a problem hiding this comment.
LGTM. I still hoped we could solve this in core (I actually did create something recently, but haven't had time to look into this properly. There is also different behavior when trying to open the port, with rfc2217 it throws a different exception when no connection can be made) @martinvw will also be happy when this is merged so he doesn't have to use his custom build version of this binding with these changes 😄
|
Yes I agree it is far from ideal to catch these exceptions in every add-on that uses these methods and also wants to support rfc2217. But on the other hand it's only a couple of extra lines and makes OH 2.5.x users more happy today. 🙂 |
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Sep 12, 2020
Signed-off-by: Wouter Born <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
Signed-off-by: Wouter Born <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Oct 8, 2020
Signed-off-by: Wouter Born <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some testing with RFC2217 and the DSMR Binding some time ago and I didn't run into any issues after catching these
UnsupportedCommOperationExceptionexceptions.A similar approach was used for ZWave in openhab/org.openhab.binding.zwave#1337.
Related to openhab/openhab-core#1462.